Repository navigation
Handle HCE-only engines that do not advertise UseNNUE - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
UseNNUEis absent from an engine's UCI options and the config requestsUseNNUE: false, Tunex treats that engine as HCE-only and does not send an unsupportedsetoptioncommand.UseNNUEis advertised, normal configuration remains unchanged.UseNNUE: trueon engines that do not advertise it still fail with strict option validation; all other missing options remain errors.Tests
Add unit tests for HCE-only skip, advertised option, strict error, and non-strict compatibility.
Reproduction
An IronPhoenix HCE-only build without
UseNNUEpreviously failed withNew engine does not advertise UCI option 'UseNNUE'while using the standardUseNNUE: falseconfig. This PR removes that false failure.